comp.lang.idl-pvwave archive: archive » Re: Patch to userlib/deriv.pro to add MAX

Home » Public Forums » archive » Re: Patch to userlib/deriv.pro to add MAX_VALUE keyword

Show: Today's Messages :: Show Polls :: Message Navigator
E-mail to friend

Re: Patch to userlib/deriv.pro to add MAX_VALUE keyword [message #1553]

Mon, 27 December 1993 15:23

thompson
Messages: 584
Registered: August 1991

Senior Member

schmitt@ccfsun.nrl.navy.mil (Andrew Schmitt) writes:

> This is somewhat besides the point of the original posting, but it has to do
> with a (granted, nitpicking) bug in the userlib routine deriv.pro.
> You might as well fix it when you make the posted patch.

> Basically, here's a use of "float(...)" in deriv.pro that is unneeded,
> and makes the resulting answer wrong and/or inaccurate if any other type
> of data (complex, double, ...&c) is passed as the Y value.
> The unneeded usage of float occurs about here:

>> d = float(shift(y,-1) - shift(y,1))/(shift(x,-1) - shift(x,1))
> ^^^^^
> remove the "float", and the applicability of the routine improves.

Not having looked at the original source code, I'm not sure if this is the
case, but one can imagine that problems could occur if the call to FLOAT is
removed and SHIFT is one of the integer types. Another way to get around this,
without leading to errors if SHIFT is double-precision or complex, is to insert
a multiplication by 1.0 somewhere, e.g.

d = (1.0*shift(y,-1) - shift(y,1))/(shift(x,-1) - shift(x,1))

Of course, this does lead to some inefficiencies.

Bill Thompson

Report message to a moderator

[Message index]

		Re: Patch to userlib/deriv.pro to add MAX_VALUE keyword By: thompson on Mon, 27 December 1993 15:23
		Re: Patch to userlib/deriv.pro to add MAX_VALUE keyword By: nowicki on Mon, 27 December 1993 02:50
		Re: Patch to userlib/deriv.pro to add MAX_VALUE keyword By: schmitt on Mon, 27 December 1993 12:34
		Re: Patch to userlib/deriv.pro to add MAX_VALUE keyword By: thompson on Mon, 27 December 1993 08:04

Previous Topic:	FORTRAN Sbrs. to Read .xdr Formatted Files?
Next Topic:	JHU/APL IDL library update notice

-=] Back to Top [=-

[ Syndicate this forum (XML) ] [

] [

]

Current Time: Tue Dec 02 02:26:15 PST 2025

Total time taken to generate the page: 1.04058 seconds